variablelab/theatre
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Add performance note about prism scopes

Browse source
This commit is contained in:
Aria Minaei 2022-11-26 23:29:19 +01:00
parent 83832ef85b
commit 0655e5b1c4
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
packages/dataverse/src/derivations/prism/prism.ts
View file

@ -106,20 +106,20 @@ export class PrismDerivation<V> extends AbstractDerivation<V> {
class PrismScope {
isPrismScope = true
private _subs: Record<string, PrismScope> = {}
// NOTE probably not a great idea to eager-allocate all of these objects/maps for every scope,
// especially because most wouldn't get used in the majority of cases. However, back when these
// were stored on weakmaps, they were uncomfortable to inspect in the debugger.
readonly subs: Record<string, PrismScope> = {}
readonly effects: Map<string, IEffect> = new Map()
readonly memos: Map<string, IMemo> = new Map()
readonly refs: Map<string, IRef<unknown>> = new Map()
sub(key: string) {
if (!this._subs[key]) {
this._subs[key] = new PrismScope()
if (!this.subs[key]) {
this.subs[key] = new PrismScope()
}
return this._subs[key]
}
get subs() {
return this._subs
return this.subs[key]
}
cleanupEffects() {