Warn about (possibly) incorrect custom camera (#308)
Print a warning if people use e.perspectiveCamera or e.orthographicCamera
This commit is contained in:
parent
3c3e0a2369
commit
3ec8c20fa6
1 changed files with 38 additions and 1 deletions
|
@ -1,5 +1,11 @@
|
|||
import type {ComponentProps, ComponentType, RefAttributes} from 'react'
|
||||
import React, {forwardRef, useLayoutEffect, useRef, useState} from 'react'
|
||||
import React, {
|
||||
forwardRef,
|
||||
useEffect,
|
||||
useLayoutEffect,
|
||||
useRef,
|
||||
useState,
|
||||
} from 'react'
|
||||
import {allRegisteredObjects, editorStore} from './store'
|
||||
import mergeRefs from 'react-merge-refs'
|
||||
import type {ISheetObject} from '@theatre/core'
|
||||
|
@ -58,6 +64,37 @@ const createEditable = <Keys extends keyof JSX.IntrinsicElements>(
|
|||
|
||||
const invalidate = useInvalidate()
|
||||
|
||||
useEffect(() => {
|
||||
if (
|
||||
Component === 'perspectiveCamera' ||
|
||||
Component === 'orthographicCamera'
|
||||
) {
|
||||
const dreiComponent =
|
||||
Component.charAt(0).toUpperCase() + Component.slice(1)
|
||||
|
||||
console.warn(
|
||||
`You seem to have declared the camera %c${theatreKey}%c simply as <e.${Component} ... />. This alone won't make r3f use it for rendering.
|
||||
|
||||
The easiest way to create a custom animatable ${dreiComponent} is to import it from @react-three/drei, and make it editable.
|
||||
|
||||
%cimport {${dreiComponent}} from '@react-three/drei'
|
||||
const EditableCamera = editable(${dreiComponent}, '${Component}')%c
|
||||
|
||||
Then you can use it in your JSX like any other editable component. Note the makeDefault prop exposed by drei, which makes r3f use it for rendering.
|
||||
|
||||
%c<EditableCamera
|
||||
theatreKey="${theatreKey}"
|
||||
makeDefault
|
||||
>`,
|
||||
'font-style: italic;',
|
||||
'font-style: inherit;',
|
||||
'background: black; color: white;',
|
||||
'background: inherit; color: inherit',
|
||||
'background: black; color: white;',
|
||||
)
|
||||
}
|
||||
}, [Component, theatreKey])
|
||||
|
||||
useLayoutEffect(() => {
|
||||
if (!sheet) return
|
||||
const sheetObject = sheet.object(
|
||||
|
|
Loading…
Reference in a new issue