From 83832ef85b43f312034e00f31eeee21805e00754 Mon Sep 17 00:00:00 2001
From: Aria Minaei <aria.minaei@gmail.com>
Date: Sat, 26 Nov 2022 22:40:04 +0100
Subject: [PATCH] Note down that map/flatMap must be removed

---
 packages/dataverse/src/derivations/AbstractDerivation.ts | 2 ++
 packages/dataverse/src/derivations/flatMap.ts            | 1 +
 packages/dataverse/src/derivations/map.ts                | 1 +
 3 files changed, 4 insertions(+)

diff --git a/packages/dataverse/src/derivations/AbstractDerivation.ts b/packages/dataverse/src/derivations/AbstractDerivation.ts
index ee5972c..1b0e25a 100644
--- a/packages/dataverse/src/derivations/AbstractDerivation.ts
+++ b/packages/dataverse/src/derivations/AbstractDerivation.ts
@@ -256,6 +256,7 @@ export default abstract class AbstractDerivation<V> implements IDerivation<V> {
    * @deprecated This is a remnant of the old monadic api. Now it's functionally equal to `prism(() => fn(der.getValue()))`, so use that instead.
    */
   map<T>(fn: (v: V) => T): IDerivation<T> {
+    // TODO once prism and AbstractDerivation are merged into one, we should replace this with prism(() => fn(der.getValue()))
     return map(this, fn)
   }
 
@@ -279,6 +280,7 @@ export default abstract class AbstractDerivation<V> implements IDerivation<V> {
   flatMap<R>(
     fn: (v: V) => R,
   ): IDerivation<R extends IDerivation<infer T> ? T : R> {
+    // TODO once prism and AbstractDerivation are merged into one, we should replace this with prism(() => val(fn(val(der))))
     return flatMap(this, fn)
   }
 }
diff --git a/packages/dataverse/src/derivations/flatMap.ts b/packages/dataverse/src/derivations/flatMap.ts
index a35c6f0..d4fa2ba 100644
--- a/packages/dataverse/src/derivations/flatMap.ts
+++ b/packages/dataverse/src/derivations/flatMap.ts
@@ -10,6 +10,7 @@ enum UPDATE_NEEDED_FROM {
 }
 
 const makeFlatMapDerivationClass = () => {
+  // TODO once prism and AbstractDerivation are merged into one, we should delete this file
   class FlatMapDerivation<V, DepType> extends AbstractDerivation<V> {
     private _innerDerivation: undefined | null | IDerivation<V>
     private _staleDependency: UPDATE_NEEDED_FROM
diff --git a/packages/dataverse/src/derivations/map.ts b/packages/dataverse/src/derivations/map.ts
index 5f5a6f1..78c661e 100644
--- a/packages/dataverse/src/derivations/map.ts
+++ b/packages/dataverse/src/derivations/map.ts
@@ -3,6 +3,7 @@ import type {IDerivation} from './IDerivation'
 
 // Exporting from a function because of the circular dependency with AbstractDerivation
 const makeMapDerivationClass = () =>
+  // TODO once prism and AbstractDerivation are merged into one, we should delete this file
   class MapDerivation<T, V> extends AbstractDerivation<V> {
     constructor(
       private readonly _dep: IDerivation<T>,