variablelab/theatre
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Support the entire getProject config in theatric's initialize() function (#384)

Browse source 
Support the entire getProject config in initialize
This commit is contained in:
Andrew Prifer 2023-01-22 22:59:29 +01:00 committed by GitHub
parent aec79bd8c4
commit 8470b67d4b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playground/src/shared/theatric/index.tsx
View file

@ -3,7 +3,7 @@ import {render} from 'react-dom'
import React, {useState} from 'react' import React, {useState} from 'react'
import state from './state.json' import state from './state.json'
initialize(state) initialize({state})
function SomeComponent({id}: {id: string}) { function SomeComponent({id}: {id: string}) {
const {foo, $get, $set} = useControls( const {foo, $get, $set} = useControls(

14
packages/theatric/src/index.ts
View file

@ -31,16 +31,16 @@ const maybeTransaction =
? studio.transaction.bind(studio) ? studio.transaction.bind(studio)
: () => {} : () => {}
let _state: IProjectConfig['state'] | undefined = undefined let _projectConfig: IProjectConfig['state'] | undefined = undefined
export function initialize(state: IProjectConfig['state']) { export function initialize(config: IProjectConfig) {
if (_state !== undefined) { if (_projectConfig !== undefined) {
console.warn( console.warn(
'Theatric has already been initialized, either through another initialize call, or by calling useControls() before calling initialize().', 'Theatric has already been initialized, either through another initialize call, or by calling useControls() before calling initialize().',
) )
return return
} }
_state = state _projectConfig = config
} }
const allProps: Record<string, UnknownShorthandCompoundProps[]> = {} const allProps: Record<string, UnknownShorthandCompoundProps[]> = {}
@ -81,8 +81,8 @@ export function useControls<Config extends ControlsAndButtons>(
$get: Getter<OmitMatching<Config, {type: 'button'}>> $get: Getter<OmitMatching<Config, {type: 'button'}>>
} { } {
// initialize state to null, if it hasn't been initialized yet // initialize state to null, if it hasn't been initialized yet
if (_state === undefined) { if (_projectConfig === undefined) {
_state = null _projectConfig = null
} }
/* /*
@ -150,7 +150,7 @@ export function useControls<Config extends ControlsAndButtons>(
) )
const sheet = useMemo( const sheet = useMemo(
() => getProject('Theatric', {state: _state}).sheet('Panels'), () => getProject('Theatric', _projectConfig ?? undefined).sheet('Panels'),
[], [],
) )
const panel = options.panel ?? 'Default panel' const panel = options.panel ?? 'Default panel'