variablelab/theatre
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Perf: Memoize SingleKeyframeEditor

Browse source
This commit is contained in:
Aria Minaei 2022-07-12 12:07:50 +02:00 committed by Aria
parent 10f21224f4
commit 8f08499fb6
2 changed files with 64 additions and 60 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
theatre/studio/src/panels/SequenceEditorPanel/DopeSheet/Right/BasicKeyframedTrack/KeyframeEditor/SingleKeyframeDot.tsx
View file

@ -95,7 +95,8 @@ const HitZone = styled.div<{isInlineEditorPopoverOpen: boolean}>`
type ISingleKeyframeDotProps = ISingleKeyframeEditorProps type ISingleKeyframeDotProps = ISingleKeyframeEditorProps
/** The ◆ you can grab onto in "keyframe editor" (aka "dope sheet" in other programs) */ /** The ◆ you can grab onto in "keyframe editor" (aka "dope sheet" in other programs) */
const SingleKeyframeDot: React.VFC<ISingleKeyframeDotProps> = (props) => { const SingleKeyframeDot: React.VFC<ISingleKeyframeDotProps> = React.memo(
(props) => {
const logger = useLogger('SingleKeyframeDot', props.keyframe.id) const logger = useLogger('SingleKeyframeDot', props.keyframe.id)
const presence = usePresence(props.itemKey) const presence = usePresence(props.itemKey)
const [ref, node] = useRefAndState<HTMLDivElement | null>(null) const [ref, node] = useRefAndState<HTMLDivElement | null>(null)
@ -132,7 +133,8 @@ const SingleKeyframeDot: React.VFC<ISingleKeyframeDotProps> = (props) => {
{contextMenu} {contextMenu}
</> </>
) )
} },
)
export default SingleKeyframeDot export default SingleKeyframeDot

6
theatre/studio/src/panels/SequenceEditorPanel/DopeSheet/Right/BasicKeyframedTrack/KeyframeEditor/SingleKeyframeEditor.tsx
View file

@ -29,7 +29,8 @@ export type ISingleKeyframeEditorProps = {
selection: undefined | DopeSheetSelection selection: undefined | DopeSheetSelection
} }
const SingleKeyframeEditor: React.VFC<ISingleKeyframeEditorProps> = (props) => { const SingleKeyframeEditor: React.VFC<ISingleKeyframeEditorProps> = React.memo(
(props) => {
const { const {
index, index,
keyframe, keyframe,
@ -55,6 +56,7 @@ const SingleKeyframeEditor: React.VFC<ISingleKeyframeEditorProps> = (props) => {
{connected ? <SingleKeyframeConnector {...props} /> : noConnector} {connected ? <SingleKeyframeConnector {...props} /> : noConnector}
</SingleKeyframeEditorContainer> </SingleKeyframeEditorContainer>
) )
} },
)
export default SingleKeyframeEditor export default SingleKeyframeEditor