From a074f184ab05da44e4b368bb8eecf89cfe9d7a31 Mon Sep 17 00:00:00 2001
From: Aria Minaei <aria.minaei@gmail.com>
Date: Sun, 8 Aug 2021 10:12:08 +0200
Subject: [PATCH] Fixed the double bundling of react

---
 theatre/devEnv/buildUtils.ts | 32 +++++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/theatre/devEnv/buildUtils.ts b/theatre/devEnv/buildUtils.ts
index f463980..e43170b 100644
--- a/theatre/devEnv/buildUtils.ts
+++ b/theatre/devEnv/buildUtils.ts
@@ -19,7 +19,29 @@ export function createBundles(watch: boolean) {
       sourcemap: true,
       define: definedGlobals,
       watch,
-      external: ['@theatre/dataverse'],
+      external: [
+        '@theatre/dataverse',
+        /**
+         * Prevents double-bundling react.
+         *
+         * @notes
+         * Ideally we'd want to just bundle our own fixed version of react to keep things
+         * simple, but for now we keep react external because we're exposing these
+         * react-dependant API from @theatre/studio:
+         *
+         * - ToolbarIconButton
+         * - IStudio['extend']({globalToolbar: {component}})
+         *
+         * These are further exposed by @theatre/plugin-r3f which provides `<Wrapper />`
+         * as an API.
+         *
+         * It's probably possible to bundle our own react version and somehow share it
+         * with the plugins, but that's not urgent atm.
+         */
+        'react',
+        'react-dom',
+        'styled-components',
+      ],
     }
 
     if (which === 'core') {
@@ -35,6 +57,14 @@ export function createBundles(watch: boolean) {
       format: 'cjs',
     })
 
+    /**
+     * @notes
+     * I just disabled ESM builds because I couldn't get them to work
+     * with create-react-app which uses webpack v4. I'm sure that's fixable,
+     * but not worth the hassle right now. There is not much to tree-shake
+     * in @theatre/core as we've done all the tree-shaking pre-bundle already.
+     */
+
     // build({
     //   ...esbuildConfig,
     //   outfile: path.join(pathToPackage, 'dist/index.mjs'),