Remove debouncedScrub()
from r3f (#147)
This commit is contained in:
parent
a38201a835
commit
a3b1938d43
2 changed files with 19 additions and 11 deletions
|
@ -6,7 +6,7 @@ import React, {
|
|||
useRef,
|
||||
useState,
|
||||
} from 'react'
|
||||
import type {Editable} from '../store';
|
||||
import type {Editable} from '../store'
|
||||
import {useEditorStore} from '../store'
|
||||
import {createPortal} from '@react-three/fiber'
|
||||
import EditableProxy from './EditableProxy'
|
||||
|
@ -15,6 +15,7 @@ import TransformControls from './TransformControls'
|
|||
import shallow from 'zustand/shallow'
|
||||
import type {Material, Mesh, Object3D} from 'three'
|
||||
import {MeshBasicMaterial, MeshPhongMaterial} from 'three'
|
||||
import type {IScrub} from '@theatre/studio';
|
||||
import studio from '@theatre/studio'
|
||||
import {useSelected} from './useSelected'
|
||||
import {useVal} from '@theatre/react'
|
||||
|
@ -213,9 +214,7 @@ const ProxyManager: VFC<ProxyManagerProps> = ({orbitControlsRef}) => {
|
|||
})
|
||||
}, [viewportShading, renderMaterials, sceneProxy])
|
||||
|
||||
const scrub = useMemo(() => {
|
||||
return studio.debouncedScrub(1000)
|
||||
}, [selected, editableProxyOfSelected])
|
||||
const scrub = useRef<IScrub>(undefined!)
|
||||
|
||||
if (!sceneProxy) {
|
||||
return null
|
||||
|
@ -237,7 +236,7 @@ const ProxyManager: VFC<ProxyManagerProps> = ({orbitControlsRef}) => {
|
|||
const sheetObject = editableProxyOfSelected.editable.sheetObject
|
||||
const obj = editableProxyOfSelected.object
|
||||
|
||||
scrub.capture(({set}) => {
|
||||
scrub.current.capture(({set}) => {
|
||||
set(sheetObject.props, {
|
||||
...sheetObject.value,
|
||||
position: {
|
||||
|
@ -258,7 +257,14 @@ const ProxyManager: VFC<ProxyManagerProps> = ({orbitControlsRef}) => {
|
|||
})
|
||||
})
|
||||
}}
|
||||
onDraggingChange={(event) => (isBeingEdited.current = event.value)}
|
||||
onDraggingChange={(event) => {
|
||||
if (event.value) {
|
||||
scrub.current = studio.scrub()
|
||||
} else {
|
||||
scrub.current.commit()
|
||||
}
|
||||
return (isBeingEdited.current = event.value)
|
||||
}}
|
||||
/>
|
||||
)}
|
||||
{Object.values(editableProxies).map(
|
||||
|
|
|
@ -4,6 +4,7 @@ import type {MutableRefObject} from 'react'
|
|||
import {useLayoutEffect, useRef} from 'react'
|
||||
import React from 'react'
|
||||
import useRefAndState from './useRefAndState'
|
||||
import type {IScrub} from '@theatre/studio';
|
||||
import studio from '@theatre/studio'
|
||||
import type {PerspectiveCamera as PerspectiveCameraImpl} from 'three'
|
||||
import type {ISheet} from '@theatre/core'
|
||||
|
@ -88,17 +89,18 @@ function usePassValuesFromOrbitControlsToTheatre(
|
|||
useLayoutEffect(() => {
|
||||
if (!cam || orbitControls == null) return
|
||||
|
||||
let currentScrub: undefined | ReturnType<typeof studio['debouncedScrub']>
|
||||
let currentScrub: undefined | IScrub
|
||||
|
||||
let started = false
|
||||
|
||||
const onStart = () => {
|
||||
started = true
|
||||
if (!currentScrub) {
|
||||
currentScrub = studio.debouncedScrub(600)
|
||||
}
|
||||
currentScrub = studio.scrub()
|
||||
}
|
||||
const onEnd = () => {
|
||||
if (currentScrub) {
|
||||
currentScrub.commit()
|
||||
}
|
||||
started = false
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue