Rename deleteObject() and related params

Since `sheet.deleteObject()` doesn't actually delete the values
of the props of that object, I decided to rename it to `detachObject()`.

Also, the param `override` sounded too similar to the concept of value overrides,
so I renamed it to `reconfigure`.
This commit is contained in:
Aria Minaei 2022-10-20 12:33:24 +02:00 committed by Aria
parent cb8fa2f20f
commit a8a9b5ef05
3 changed files with 28 additions and 13 deletions

View file

@ -135,7 +135,7 @@ Then you can use it in your JSX like any other editable component. Note the make
(value) => value.type,
),
),
{override: true},
{reconfigure: true},
)
return
} else {
@ -212,7 +212,7 @@ Then you can use it in your JSX like any other editable component. Note the make
return () => {
untap()
sheetObject.sheet.deleteObject(theatreKey)
sheetObject.sheet.detachObject(theatreKey)
allRegisteredObjects.delete(sheetObject)
editorStore.getState().removeEditable(storeKey)
}