variablelab/theatre
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix the bug where react would complain if SnapshotEditor is unmounted

Browse source
This commit is contained in:
Aria Minaei 2023-08-05 09:59:43 +02:00
parent e153c4cbbb
commit af1964f9ac
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/r3f/src/extension/index.ts
View file

@ -150,7 +150,10 @@ const r3fExtension: IExtension = {
root.render(React.createElement(SnapshotEditor, {paneId})) root.render(React.createElement(SnapshotEditor, {paneId}))
function unmount() { function unmount() {
// gotta unmount in the next tick, otherwise react will complain https://github.com/facebook/react/issues/25675
setTimeout(() => {
root.unmount() root.unmount()
}, 0)
} }
return unmount return unmount
}, },