variablelab/theatre
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Allow re-registering the exact same extension

Browse source
This commit is contained in:
Aria Minaei 2022-09-17 19:44:19 +02:00 committed by Aria
parent 5bb4fc9340
commit c4862ee6ef
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
theatre/studio/src/Studio.ts
View file

@ -22,6 +22,7 @@ import type {Deferred} from '@theatre/shared/utils/defer'
import {defer} from '@theatre/shared/utils/defer' import {defer} from '@theatre/shared/utils/defer'
import type {ProjectId} from '@theatre/shared/utils/ids' import type {ProjectId} from '@theatre/shared/utils/ids'
import checkForUpdates from './checkForUpdates' import checkForUpdates from './checkForUpdates'
import shallowEqual from 'shallowequal'
export type CoreExports = typeof _coreExports export type CoreExports = typeof _coreExports
@ -223,6 +224,15 @@ export class Studio {
this.transaction(({drafts}) => { this.transaction(({drafts}) => {
if (drafts.ephemeral.extensions.byId[extension.id]) { if (drafts.ephemeral.extensions.byId[extension.id]) {
const prevExtension = drafts.ephemeral.extensions.byId[extension.id]
if (
extension === prevExtension ||
shallowEqual(extension, prevExtension)
) {
// probably running studio.extend() several times because of hot reload.
// as long as it's the same extension, we can safely ignore.
return
}
throw new Error(`Extension id "${extension.id}" is already defined`) throw new Error(`Extension id "${extension.id}" is already defined`)
} }