variablelab/theatre
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove useless TS type (#318)

Browse source
This commit is contained in:
Andrew Prifer 2022-10-17 16:13:23 +02:00 committed by GitHub
parent 29e036638b
commit e708463377
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
packages/r3f/src/main/editable.tsx
View file

@ -191,20 +191,18 @@ Then you can use it in your JSX like any other editable component. Note the make
primitive: editable('primitive', null), primitive: editable('primitive', null),
} as unknown as { } as unknown as {
[Property in Keys]: React.ForwardRefExoticComponent< [Property in Keys]: React.ForwardRefExoticComponent<
React.PropsWithRef< Omit<JSX.IntrinsicElements[Property], 'visible'> & {
Omit<JSX.IntrinsicElements[Property], 'visible'> & { theatreKey: string
theatreKey: string visible?: boolean | 'editor'
visible?: boolean | 'editor' additionalProps?: $FixMe
additionalProps?: $FixMe objRef?: $FixMe
objRef?: $FixMe // not exactly sure how to get the type of the threejs object itself
// not exactly sure how to get the type of the threejs object itself ref?: Ref<unknown>
ref?: Ref<unknown> }
}
>
> >
} & { } & {
primitive: React.ForwardRefExoticComponent< primitive: React.ForwardRefExoticComponent<
React.PropsWithRef<{ {
object: any object: any
theatreKey: string theatreKey: string
visible?: boolean | 'editor' visible?: boolean | 'editor'
@ -213,7 +211,7 @@ Then you can use it in your JSX like any other editable component. Note the make
editableType: keyof JSX.IntrinsicElements editableType: keyof JSX.IntrinsicElements
// not exactly sure how to get the type of the threejs object itself // not exactly sure how to get the type of the threejs object itself
ref?: Ref<unknown> ref?: Ref<unknown>
}> & { } & {
// Have to reproduce the primitive component's props here because we need to // Have to reproduce the primitive component's props here because we need to
// lift this index type here to the outside to make auto-complete work // lift this index type here to the outside to make auto-complete work
[props: string]: any [props: string]: any